mbk/pesterchum
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replaced unnecessary use of eval() in usermode icon function.

Browse source 
Don't think this was possible to abuse, but it's probably better to avoid eval anyway since it's a potential security risk.
This commit is contained in:
Dpeta 2022-11-02 20:34:38 +01:00
parent 5cbf2eb917
commit 8d1bef4db2
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
memos.py
View file

@ -1510,13 +1510,17 @@ class PesterMemo(PesterConvo):
def iconCrap(self, c, down=True): def iconCrap(self, c, down=True):
for m in self.umodes if down else reversed(self.umodes): for m in self.umodes if down else reversed(self.umodes):
if eval("c." + m): # These if attr used to be an if eval("c." + m),
if m == "box": # better not to use eval() unnecessarily for security reasons though.
icon = PesterIcon("smilies/box.png") # Hopefully this works fine too.
else: if hasattr(c, str(m)):
icon = PesterIcon(self.mainwindow.theme["memos/" + m + "/icon"]) if getattr(c, str(m)):
c.setIcon(icon) if m == "box":
return icon = PesterIcon("smilies/box.png")
else:
icon = PesterIcon(self.mainwindow.theme[f"memos/{m}/icon"])
c.setIcon(icon)
return
icon = QtGui.QIcon() icon = QtGui.QIcon()
c.setIcon(icon) c.setIcon(icon)